• kevincox@lemmy.ml
    link
    fedilink
    arrow-up
    3
    ·
    edit-2
    2 months ago

    I don’t understand. Why does having two commit IDs with the exact same code cause problems.

    A green “Verified” badge on GitHub is supposed to mean that a trusted author signed it

    The author did sign it. It is the exact same code.

    An attacker can reissue the same signed code under a fresh ID that’s still verified to slip past.

    To split past what? At best it seems that they would be able to have a different ID for the exact same code, which seems harmless? Slightly confusing at worst.

    Nix also doesn’t use PGP signatures, it requires a separate hash of the resulting commit (the files with the .git directory stripped by default).

    • jatone@lemmy.dbzer0.com
      link
      fedilink
      English
      arrow-up
      2
      ·
      edit-2
      2 months ago

      sounds like the author thinks because their purist definition is violated its a problem vs it actually being a problem. im in the same boat as you. I dont see the issue with the commit hash changing long as the code doesnt change.

    • ☆ Yσɠƚԋσʂ ☆@lemmy.mlOP
      link
      fedilink
      arrow-up
      2
      ·
      2 months ago

      Right, it’s not a serious exploit which would allow changing code, but it does allow compromising integrity because changing the id mutates history.

      • kevincox@lemmy.ml
        link
        fedilink
        arrow-up
        1
        ·
        2 months ago

        It doesn’t mutate history. It just creates a new branch of history in their own fork. Just like any new commit would do.

          • kevincox@lemmy.ml
            link
            fedilink
            arrow-up
            1
            ·
            2 months ago

            Please explain what you mean and how this could be abused. What does “real” mean in this context? They both have the same code. It would probably help if you can provide a specific attack that could actually cause harm rather than just stating facts that have unclear risk.

            • ☆ Yσɠƚԋσʂ ☆@lemmy.mlOP
              link
              fedilink
              arrow-up
              1
              ·
              2 months ago

              My understanding is that you’d end up with two divergent histories and you can’t tell which one is the original. I don’t know how it could be abused off top of my head, but generally speaking people tend to find ways to abuse these kinds of things.