For example:
class FooBar:
def __init__(self):
self.a: int = None
self.foo: str = None
Is this bad practice/go against PEP guidelines or is it fine?
Implicit optional is deprecated. Explicitly use
self.foo: int | None = NoneThanks! Good to know.
yes, bad practice; yes, against PEP
That seems like that’s going to give you an error in most type checkers. You said it’s always an int and then immediate made that a lie and made it None instead.
Why are you trying to do this?
I’m initializing variables that would be used later in the class in different functions. I wasn’t sure if I needed to do a
var: <type> | None = Noneor if just setting it to None was fine.I’m going to say initializing them to None and updating them later is a code smell. If you can do so, make them non-optional and always initialize them to actual meaningful values.
Yeah, if you initialize them to None then for the entire rest of the class you’re going to have to account for the possibility that they’re None. If it’s unavoidable that they might be None, you should type it as such.
If you type them as like
str | Nonethen later when you do likereturn foo[0]it will warn you that you can’t do that with None.foo[0] is also unsafe unless foo is known to be nonempty, ofc.
Technically correct , the best kind of correct.
foo.lower()would have been a better example.
Why not require values in the constructor?
This is an example. For my actual use case, they would be private vars that would be set by class functions instead of passed to the constructor.
If it can be None then the type is Optional[int] or Optional[str] as the case may be. Or I guess now int | None etc. I’m used to older versions of mypy so idk if they support that alternate syntax.
Optional[int] would seem to be preferable but it turns out it’s not really an option type. Like Optional[None] being None is ambiguous.
