• RidcullyTheBrown@programming.dev
    link
    fedilink
    arrow-up
    3
    ·
    1 day ago

    after spending like two hours fixing all the syntax errors

    If the code has syntax errors then clearly the tests don’t pass. A minimum requirement to start reviewing a PR should be that the tests all pass.

    • jtrek@startrek.website
      link
      fedilink
      arrow-up
      1
      ·
      19 hours ago

      Hahaha! They don’t write tests. They are unfamiliar with the concept of unit testing.

      I had to explain to them the concept of “you import your function and call it with different arguments to make sure it returns what you expect”. It took a couple tries.

      Meanwhile, the head of the “quality” team keeps telling me that I should stay in my lane and not tell the developers how to do their work.