• 16 Posts
  • 658 Comments
Joined 3 years ago
cake
Cake day: July 10th, 2023

help-circle

  • You must work in dreadful places. I’ve seen it a few times, but most places have been productive.

    It needs a good lead dev to set the culture though.

    Whitespace change debates can be avoided by using rule sets in IDEs and agreeing standards within the team.

    Good static code analysis tools in pipelines and IDEs handle most technical issues leaving reviewers to focus on design, maintainability, clarity and readability.

    You can avoid pickiness if you communicate why, so they learn and understand. If you use PRs as a training and learning tool they’re quite productive. If not sure, ask why something was done.

    And if you get picky comments respond with “personal preference and not part of team rules”. But also, you cannot be defensive in your PRS. You have to be open to feedback and points and happy to discuss. Be polite even when feedback is invalid. Defendivesness kills constructive feedback and no matter how old you are and how long you’ve been doing it, you can still improve. Oh and if you been doing it that long, you’re a senior or lead and can influence how things are done.















  • Shame he didn’t spend time reading up on SOLID principles, clean code, refactoring and TDD. Sounds like Jr parading as a senior. Product nerd != good developer.

    Most seniors got burned so much, they refuse to build complex unsupportable stuff. KISS is king with top devs.

    The fact this dude has the most experience says everything about your orgs hiring processes. Cheaping out on senior salaries.